-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add single comment when reviewing code in deleted file generates fatal: no such path #4752
Closed
2 of 8 tasks
Comments
mkienenb
changed the title
add single comment when reviewing code in deleted file generates fatal: no such path
Add single comment when reviewing code in deleted file generates fatal: no such path
Aug 20, 2018
@lafriks Ping. |
Was PR created from fork on same repository other branch? |
It's hard to understand what you are asking. User A owns the repo. User B is a collaborator (administrator) for the repo. |
lafriks
added a commit
to lafriks-fork/gitea
that referenced
this issue
Sep 16, 2018
PR #4682 fixes this issue |
lafriks
added a commit
that referenced
this issue
Sep 17, 2018
* Code review UI improvements * More fixes to dark theme * Style fix * Fix to allow add code review comments only on review files tab * More readability dark style fixes * Fix commenting on deleted files. Fixes #4752 * Fix line blame getting for multiple corner cases
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Gitea version (or commit ref):
/var/lib/gitea>sudo /usr/local/bin/gitea --version
Gitea version 1b2aff0 built with: bindata, sqlite
[master snapshot grabbed on Aug 15th]
Git version:
git version 2.18.0
Operating system:
CentOS release 6.4 (Final)
Database (use
[x]
):Can you reproduce the bug at https://try.gitea.io:
Log gist:
2018/08/20 09:29:23 [.../repo/pull_review.go:77 CreateCodeComment()] [E] CreateCodeComment: LineBlame[refs/pull/1/head, /home/git/gitea-repositories/mlk/ebill.git, WEB-INF/lib/.gitignore, 1]: exit status 128 - fatal: no such path WEB-INF/lib/.gitignore in refs/pull/1/head
Description
Attempting to add a review comment to a deleted file generates an error and
Generates log entry above. Redirects to 500 Internal Server Error page.
Screenshots
See before and after here.
https://gist.github.com/mkienenb/016013ce9a50653ec02859d9fff14415
The text was updated successfully, but these errors were encountered: