API /admin/users/{username} Edit an existing user is missing for allow_create_organization

[EnricoFerro]

• Gitea version (or commit ref): Actual ( Probably from d67b278 )
• Git version:
• Operating system:
• Database (use [x]):
  • [ x] PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • [ x] Yes
  • No
  • Not relevant
• Log gist:

Description

In the user setting is possible to set the creation of the organization from the flag "May Create Organizations"

The API EDIT USER /admin/users/{username} is missing of the flag allow_create_organization in the Model that simulate this flag

Changes

This is a ( probably incomplete ) list of the files to modify (Sorry I don't know Go... :-( )
File to modify:

gitea/routers/api/v1/admin/user.go

Line 157 in 6ca8fbd

adding lines:

if form.AllowCreateOrganization != nil {
u.AllowCreateOrganization = *form.AllowCreateOrganization
}

---

gitea/templates/swagger/v1_json.tmpl

Line 6503 in 6ca8fbd

"allow_import_local": {

adding lines:

"allow_create_organization": {
"type": "boolean",
"x-go-name": "AllowCreateOrganization"
},

[daviian]

I think we should also discuss aligning the API models for user creation and editing? Or am I missing a detail why these are different in the first place?

[EnricoFerro]

For the creation and edit there are a lot of difference in the frontend.
I agree in an a scenario of FULL Rest API the creation is missing of a lot of information.

In the actual scenario the API follow the frontend ( without the : May Create Organization and Disable Sign-In )
Creation: API have more field than the frontend
Edit: is missing for the API prohibit_login and allow_create_organization

CREATION:

Field	Type	Mapping ( Frontend )
email	string	Email Address
full_name	string	( Not present )
login_name	string	???
password*	string	Password
send_notify	boolean	Send User Registration
source_id	integer($int64)	Authentication Source
username*	string	Username

EDIT:

Field	Type	Mapping ( Frontend )
active	boolean	User Account Is Activated
admin	boolean	Is Administrator
allow_git_hook	boolean	May Create Git Hooks
allow_import_local	boolean	May Import Local Repository
email*	string($email)	Email Address
full_name	string	Full Name
location	string	Location
login_name	string	???
max_repo_creation	integer($int64)	Maximal Number of Repositories
password	string	Password
source_id	integer($int64)	Authentication Source
website	string	Website
prohibit_login	boolean	Disable Sign-In
allow_create_organization	boolean	Is Administrator

[EnricoFerro]

Create a Pull request #4774 that implement this Isssue
Create a Pull request #4775 that implement this Isssue

[EnricoFerro]

#4775 Merged.