Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to auto-watch on first interaction #7512

Closed
1 of 6 tasks
guillep2k opened this issue Jul 18, 2019 · 6 comments
Closed
1 of 6 tasks

Option to auto-watch on first interaction #7512

guillep2k opened this issue Jul 18, 2019 · 6 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@guillep2k
Copy link
Member

  • Gitea version (or commit ref): Gitea version 1.8.3+2-g11f6ed4 built with go1.12.6 : pam, bindata, sqlite, sqlite_unlock_notify
  • Git version: 1.8.3.1
  • Operating system: CentOS 7
  • Database (use [x]):
    • [*] PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

In the spirit of AUTO_WATCH_NEW_REPOS, it would be nice to have options to automatically add the user as a watcher on first interactions, like:

  • AUTO_WATCH_ON_CHANGES = true: any write operation on a server's repository (like push) will subscribe the user to the repository.
  • AUTO_WATCH_ON_CLONE = true: clone (u other relevant operations) will subscribe the user to the repository.
  • AUTO_ORG_MEMBER_VISIBLE = true: member is visibile by default.
@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Jul 18, 2019
@6543
Copy link
Member

6543 commented Oct 15, 2019

i think this is related: #8243

@lunny
Copy link
Member

lunny commented Oct 15, 2019

They should be the same.

@strk
Copy link
Member

strk commented Oct 28, 2019

It should be "auto-subscribe", as "watch" is for all activities of a repository ?

@guillep2k
Copy link
Member Author

It should be "auto-subscribe", as "watch" is for all activities of a repository ?

@strk My original idea was to watch the entire repo after the users commits/pushes anything to it. It's implemented in #7657, but that PR is not up-to-date.

This is not the same as #7512. This is for subscribing to repos when commiting to them, while #8243 is for subscribing to issues that one creates. Sorry about my lousy description here.

@guillep2k
Copy link
Member Author

This has been implemented to a satisfactory level. Suscription upon cloning could be implemented as well, but that would be very difficult to do as git has no hook to catch a clone operation (it had one but it was removed long ago).

Closing this.

@6543
Copy link
Member

6543 commented Dec 1, 2019

@guillep2k think this is fine for now :D

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

4 participants