Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cached repository archives grow space occupation indefinitevely #769

Closed
strk opened this issue Jan 26, 2017 · 5 comments · Fixed by #885
Closed

Cached repository archives grow space occupation indefinitevely #769

strk opened this issue Jan 26, 2017 · 5 comments · Fixed by #885
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Milestone

Comments

@strk
Copy link
Member

strk commented Jan 26, 2017

Repository archives are only deleted upon explicit request ("Delete all repository archives" from admin dashboard). This results in an indefinite grow of disk space occupation. It may be good to allow for a periodic cleanup instead, maybe based on last access time.

@lunny lunny added this to the 1.x.x milestone Jan 26, 2017
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jan 26, 2017
@minecrafter
Copy link
Contributor

I've completed a first implementation for this. I will be testing it tomorrow.

@tboerger
Copy link
Member

tboerger commented Feb 9, 2017

I've completed a first implementation for this. I will be testing it tomorrow.

When you got a PR we can update the milestone related to that.

minecrafter added a commit to minecrafter/gitea that referenced this issue Feb 10, 2017
Fixes go-gitea#769

Signed-off-by: Andrew <write@imaginarycode.com>
@lunny lunny modified the milestones: 1.1.0, 1.x.x Feb 10, 2017
lunny pushed a commit that referenced this issue Feb 11, 2017
* Implement archive cleanup

Fixes #769

Signed-off-by: Andrew <write@imaginarycode.com>

* Make sure to close the directory file

* Resolve issues noted by @strk

* edit cheatsheet app.ini [ci skip]

* oops [ci skip]
@richbl
Copy link

richbl commented Mar 15, 2017

Not sure where best to ask this question but, what's the purpose of these repo archives? Are these generated when a project release is made, or are they generated at some regular interval?

Thanks

Rich

@lunny
Copy link
Member

lunny commented Mar 16, 2017

@richbl when you download an archive from the repo UI, then it will produce an archive in your server disk, not only release.

@richbl
Copy link

richbl commented Mar 16, 2017

@lunny, thanks. I see that now.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants