Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename import paths: "github.com/gogits/gogs" -> "github.com/go-gitea/gitea" #1

Merged
merged 1 commit into from
Nov 2, 2016
Merged

Rename import paths: "github.com/gogits/gogs" -> "github.com/go-gitea/gitea" #1

merged 1 commit into from
Nov 2, 2016

Conversation

andreynering
Copy link
Contributor

No description provided.

tboerger
tboerger approved these changes Nov 2, 2016
View reviewed changes
Copy link
Member

@tboerger tboerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not checked if everything have been replaced but looks good to me

strk
strk reviewed Nov 2, 2016
View reviewed changes
cmd/serve.go
"github.com/gogits/gogs/modules/httplib"
"github.com/gogits/gogs/modules/log"
"github.com/gogits/gogs/modules/setting"
"github.com/go-gitea/gitea/models"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are relative imports not supported ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is supported but not recommended

strk
strk reviewed Nov 2, 2016
View reviewed changes
Copy link
Member

@strk strk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's a way to use relative imports, it would be simpler to maintain in case of another switch

bkcsoft
bkcsoft approved these changes Nov 2, 2016
View reviewed changes
Copy link
Member

@bkcsoft bkcsoft left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhasse
Copy link

jhasse commented Nov 2, 2016

You'll need search-and-replace anyway ;)

@metalmatze
Copy link
Contributor

LGTM, small rant: Golang team now adds aliases, but we still don't have a tool for this. :)

@tboerger
Copy link
Member

tboerger commented Nov 2, 2016

LGTM

@tboerger tboerger added this to the 1.0.0 milestone Nov 2, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Nov 2, 2016

LGTM

(need to do it again -.-)

@bkcsoft
Copy link
Member

bkcsoft commented Nov 2, 2016

LGTM

Third times the charm!

@tboerger tboerger merged commit 142d35e into go-gitea:master Nov 2, 2016
@andreynering andreynering deleted the import-paths branch November 2, 2016 19:43
@tboerger tboerger added the type/enhancement An improvement of existing functionality label Nov 3, 2016
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
@kolaente kolaente mentioned this pull request Jul 22, 2017
Closed
@kolaente kolaente mentioned this pull request Sep 17, 2017
Merged
@free1139 free1139 mentioned this pull request Nov 22, 2017
Closed
@snelweg snelweg mentioned this pull request Dec 13, 2017
Closed
5 tasks
@feakuru feakuru mentioned this pull request Feb 28, 2018
Closed
7 tasks
@ghost ghost mentioned this pull request Apr 4, 2018
Closed
7 tasks
@r10r r10r mentioned this pull request Jun 5, 2018
Closed
6 tasks
@bkroll bkroll mentioned this pull request Jul 11, 2018
Closed
7 tasks
@manuth manuth mentioned this pull request Jul 12, 2018
Closed
7 tasks
@xor-gate xor-gate mentioned this pull request Jul 16, 2018
Closed
2 tasks
@Aragur Aragur mentioned this pull request Jul 20, 2018
Closed
2 tasks
@pzillmann pzillmann mentioned this pull request Jul 30, 2018
Closed
7 tasks
@RyanSquared RyanSquared mentioned this pull request Sep 19, 2018
Closed
7 tasks
@pcopissa pcopissa mentioned this pull request Oct 10, 2018
Closed
7 tasks
@pcopissa pcopissa mentioned this pull request Oct 18, 2018
Closed
6 tasks
@alexmejiaec alexmejiaec mentioned this pull request Apr 22, 2019
Closed
6 tasks
@sitilge sitilge mentioned this pull request May 1, 2019
Closed
7 tasks
@heavygit heavygit mentioned this pull request May 13, 2019
Closed
7 tasks
@Frickeldave Frickeldave mentioned this pull request May 15, 2019
Closed
7 tasks
@tcpluess tcpluess mentioned this pull request May 22, 2019
Closed
7 tasks
@zeripath zeripath mentioned this pull request Jun 21, 2019
Closed
1 task
@MayhemBill MayhemBill mentioned this pull request Jul 20, 2019
Closed
7 tasks
@argv-minus-one argv-minus-one mentioned this pull request Aug 13, 2019
Closed
7 tasks
@tester0077 tester0077 mentioned this pull request Aug 17, 2019
Closed
7 tasks
@mrsdizzie mrsdizzie mentioned this pull request Aug 26, 2019
Closed
GoodERPJeff referenced this pull request in osbzr/gitea Oct 27, 2019
@GoodERPJeff
fix #1
f324664
@gewure gewure mentioned this pull request Nov 8, 2019
Closed
@bigemon bigemon mentioned this pull request Nov 9, 2019
Closed
7 tasks
@MarkusAmshove MarkusAmshove mentioned this pull request Nov 16, 2019
Closed
7 tasks
@lhooge lhooge mentioned this pull request Nov 26, 2019
Closed
7 tasks
@zeripath zeripath mentioned this pull request Jan 7, 2020
Merged
@Albirew Albirew mentioned this pull request Jan 8, 2020
Open
@Aryesia Aryesia mentioned this pull request Jan 17, 2020
Closed
7 tasks
@0x6d61726b 0x6d61726b mentioned this pull request Feb 2, 2020
Closed
7 tasks
@teajay-fr teajay-fr mentioned this pull request Mar 2, 2020
Closed
5 tasks
@ghost ghost mentioned this pull request Apr 16, 2020
Closed
7 tasks
@silverwind silverwind mentioned this pull request Apr 17, 2020
Closed
@axil axil mentioned this pull request May 2, 2020
Closed
7 tasks
@mimicode mimicode mentioned this pull request Jun 2, 2020
Closed
@4oo4 4oo4 mentioned this pull request Jun 7, 2020
Closed
7 tasks
@somera somera mentioned this pull request Jun 18, 2020
Closed
7 tasks
@fansat fansat mentioned this pull request Sep 11, 2020
Closed
7 tasks
@jsreynolds jsreynolds mentioned this pull request Sep 11, 2020
Closed
7 tasks
@ramasoft-dv ramasoft-dv mentioned this pull request Oct 28, 2020
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@strk strk strk left review comments

@bkcsoft bkcsoft bkcsoft approved these changes

@tboerger tboerger tboerger approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@andreynering @jhasse @metalmatze @tboerger @bkcsoft @strk