Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the initial commit status to Success otherwise it will always be Pending #10317

Merged
merged 2 commits into from
Feb 17, 2020
Merged

Set the initial commit status to Success otherwise it will always be Pending #10317

merged 2 commits into from
Feb 17, 2020

Conversation

zeripath
Copy link
Contributor

The commit status code has a bug whereby setting the initial status to Pending means you can never have the status of Success - it should be set to Success.

@zeripath zeripath added type/bug issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP labels Feb 17, 2020
@zeripath zeripath added this to the 1.12.0 milestone Feb 17, 2020
@zeripath zeripath mentioned this pull request Feb 17, 2020
Merged
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 17, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 17, 2020
@zeripath zeripath changed the title Set the initial status to Success otherwise it will always be Pending Set the initial commit status to Success otherwise it will always be Pending Feb 17, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@6aeaac0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10317   +/-   ##
=========================================
  Coverage          ?   43.71%           
=========================================
  Files             ?      585           
  Lines             ?    81015           
  Branches          ?        0           
=========================================
  Hits              ?    35417           
  Misses            ?    41214           
  Partials          ?     4384

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aeaac0...b3c3371. Read the comment docs.

@zeripath zeripath merged commit e96f354 into go-gitea:master Feb 17, 2020
@zeripath zeripath deleted the fix-always-status-pending branch February 17, 2020 20:22
zeripath added a commit that referenced this pull request Feb 17, 2020
@zeripath
Set the initial commit status to Success otherwise it will always be …
117dcf1 
…Pending (#10317) (#10318)

Backport #10317

The commit status code has a bug whereby setting the initial status to Pending means you can never have the status of Success - it should be set to Success.
@zeripath zeripath added the backport/done All backports for this PR have been created label Feb 18, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kolaente kolaente kolaente approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zeripath @codecov-io @kolaente @jolheiser @GiteaBot