Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong num closed issues on repository when close issue via commit #10364

Merged
merged 2 commits into from
Feb 20, 2020
Merged

Fix wrong num closed issues on repository when close issue via commit #10364

merged 2 commits into from
Feb 20, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 19, 2020 •
edited
Loading

Will fix #10360, added a test for edit issue and also add a test for create issue.

@lunny lunny added this to the 1.12.0 milestone Feb 19, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 20, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 20, 2020
@lafriks lafriks merged commit efbd7ca into go-gitea:master Feb 20, 2020
@lunny lunny deleted the lunny/fix_wrong_num_closed_issues branch February 20, 2020 09:57
lunny added a commit to lunny/gitea that referenced this pull request Feb 20, 2020
@lunny @lafriks
Fix wrong num closed issues on repository when close issue via commit (…
6bdbf1b 
…go-gitea#10364)

Co-authored-by: Lauris BH <lauris@nix.lv>
@lunny lunny mentioned this pull request Feb 20, 2020
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Feb 20, 2020
sapk pushed a commit that referenced this pull request Feb 20, 2020
@lunny @lafriks
Fix wrong num closed issues on repository when close issue via commit (…
34e3644 
…#10364) (#10380)

Co-authored-by: Lauris BH <lauris@nix.lv>

Co-authored-by: Lauris BH <lauris@nix.lv>
@bkraul bkraul mentioned this pull request Feb 28, 2020
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Issue counter on issues tab does not decrease when closing issues via commits
4 participants
@lunny @lafriks @guillep2k @GiteaBot