Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Octicon fixes #10386

Merged
merged 3 commits into from
Feb 20, 2020
Merged

More Octicon fixes #10386

merged 3 commits into from
Feb 20, 2020

Conversation

jolheiser
Copy link
Member

Just a few more SVG fixes I've noticed as I interact with gitea.com

Changing the padding-right to margin-right fixes the compare icon.
margin-before
margin-after

This one has actually been present since before the SVGs, it's just that the wrong font never took up room so it went unnoticed. 😉
Can you spot the difference?
org-before
org-after

A popular repository will gain many repos stars
star-before
star-after

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser jolheiser added type/bug topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Feb 20, 2020
@jolheiser jolheiser added this to the 1.12.0 milestone Feb 20, 2020
@jolheiser
Copy link
Member Author

I considered adding the "correct" octicon for the org repo create, but I decided to remove it instead as none of the other buttons on that page have an icon.

context

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 20, 2020
@codecov-io
Copy link

codecov-io commented Feb 20, 2020

Codecov Report

Merging #10386 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10386      +/-   ##
==========================================
- Coverage   43.73%   43.71%   -0.02%     
==========================================
  Files         586      586              
  Lines       81113    81113              
==========================================
- Hits        35471    35458      -13     
- Misses      41250    41263      +13     
  Partials     4392     4392
Impacted Files Coverage Δ
services/pull/check.go 31.09% <0%> (-7.32%) ⬇️
modules/git/command.go 86.95% <0%> (-2.61%) ⬇️
services/pull/temp_repo.go 29.05% <0%> (-2.57%) ⬇️
services/pull/patch.go 60.37% <0%> (-2.52%) ⬇️
routers/repo/view.go 39.06% <0%> (-0.85%) ⬇️
models/error.go 30.4% <0%> (-0.55%) ⬇️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
services/pull/pull.go 33.93% <0%> (+1.5%) ⬆️
models/notification.go 65.18% <0%> (+1.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9baed03...bd8b75a. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 20, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 20, 2020
@jolheiser jolheiser merged commit ac18c3f into go-gitea:master Feb 20, 2020
@jolheiser jolheiser deleted the octicon_fixes branch February 20, 2020 23:44
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants