Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update markbates/goth #10444

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Update markbates/goth #10444

merged 1 commit into from
Feb 24, 2020

Conversation

oscarlofwenhamn
Copy link
Contributor

@oscarlofwenhamn oscarlofwenhamn commented Feb 24, 2020 •
edited
Loading

Update markbates/goth to 1.62.2

  • Fixes a JWT decoding issue in the OpenID provider
  • Updates the GitHub provider to use the authorization header for authentication
  • Updates the Twitch provider for Twitch's v5 API changes
  • Adds the email and is_private_email fields to the Apple provider's GetUser implementation
  • Modifies gothic to export a non-collidable context key for setting the Provider in a context.Context
  • Adds new scopes to the Spotify provider
  • Adds the IDToken from OpenID providers on the user struct
  • Make Apple provider's SecretParams public
  • Adds support for sign in with Apple, and drops support for Go versions 1.7 and 1.8
  • Fixes the Slack provider's FetchURL logic to use the appropriate scope for the info it needs

Update markbates/goth
b981df3 
- Fixes a JWT decoding issue in the OpenID provider
- Updates the GitHub provider to use the authorization header for authentication
- Updates the Twitch provider for Twitch's v5 API changes
- Adds the email and is_private_email fields to the Apple provider's GetUser implementation
- Modifies gothic to export a non-collidable context key for setting the Provider in a context.Context
- Adds new scopes to the Spotify provider
- Adds the IDToken from OpenID providers on the user struct
- Make Apple provider's SecretParams public
- Adds support for sign in with Apple, and drops support for Go versions 1.7 and 1.8
- Fixes the Slack provider's FetchURL logic to use the appropriate scope for the info it needs
Signed-off-by: Oscar LÃfwenhamn <oscar.lofwenhamn@cgi.com>
@techknowlogick techknowlogick added this to the 1.12.0 milestone Feb 24, 2020
@techknowlogick
Copy link
Member

Note: I've applied bug as label due to Github terminating the functionality that is used to auth users June 1, this is also why I've applied backport label.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 24, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 24, 2020
@oscarlofwenhamn
Copy link
Contributor Author

Super, and thanks for the quick review.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 24, 2020
@oscarlofwenhamn
Copy link
Contributor Author

Test successful and ready for merging.

@techknowlogick techknowlogick merged commit 0eeee9c into go-gitea:master Feb 24, 2020
@techknowlogick
Copy link
Member

@oscarlofwenhamn thanks much :) could you also backport these changes to the release/v1.11 branch?

@oscarlofwenhamn
Copy link
Contributor Author

I'd be happy to! Does that mean I make another PR with release/v1.11 as the target, or rather I checkout the release/v1.11 branch; patch and then make a new PR? I'm guessing the latter, but always best to check.

@techknowlogick
Copy link
Member

That's correct, it'd be the latter. If you have any other questions please don't hesitate to ask :)

@oscarlofwenhamn
Copy link
Contributor Author

Great, I'll get on it immediately. Cheers! And again, thanks for the fast responses, nice interacting actively. :)

@oscarlofwenhamn oscarlofwenhamn deleted the goth-update branch February 24, 2020 17:14
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Feb 24, 2020
@techknowlogick techknowlogick mentioned this pull request Feb 24, 2020
Closed
@zeripath zeripath added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Mar 6, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@oscarlofwenhamn @techknowlogick @6543 @zeripath @GiteaBot