-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System-wide webhooks #10546
System-wide webhooks #10546
Conversation
@lafriks Oh yep! false and 0 should be different things... 👍 |
Looking at what's currently there, there's no API for default webhooks. Should I look at trying to add that for both default and system webhooks (maybe another PR) or just leave everything as-is? |
You can leave that for different PR. If code is too large it is harder to review and it takes more time to get it merged |
Codecov Report
@@ Coverage Diff @@
## master #10546 +/- ##
==========================================
- Coverage 43.78% 43.7% -0.08%
==========================================
Files 586 587 +1
Lines 81764 81836 +72
==========================================
- Hits 35798 35769 -29
- Misses 41531 41623 +92
- Partials 4435 4444 +9
Continue to review full report at Codecov.
|
cb03e88
to
a2a182e
Compare
Based on the default webhook ones
a2a182e
to
cadb482
Compare
This reverts commit 191a20a.
Please resolve the conflicts |
Make lgtm work |
What about adding a |
#10545 was indeed too basic. This PR attempts to add webhooks that work system-wide, regardless of repository. The intent is to allow a savvy sysadmin to extend Gitea's functionality by being able to listen for all events - opened PRs/comments to add Jira cards to, deleting Docker images for the repo, etc. This also leaves default webhooks intact with a lot of code reuse but I fear it may be a tad confusing.
Tasks:
hooks
andsystem-hooks
reusing the same handlers...and probably something else
I'm more than happy to receive any feedback. This is my biggest PR so far but I'm growing quite fond of Go! 🚀