Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename scripts to build and add revive command as a new build tool command #10942

Merged
merged 2 commits into from
Apr 3, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 3, 2020

This PR introduces a new directory build that could store all the tool commands to build gitea. It will reduce the network requests when building because the dependent libraries will be vendored in vendor. But it will also increase the size of gitea's binary.

@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Apr 3, 2020
@techknowlogick techknowlogick added this to the 1.12.0 milestone Apr 3, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 3, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 3, 2020
@lafriks lafriks merged commit 4f63f28 into go-gitea:master Apr 3, 2020
@lunny lunny deleted the lunny/vendor_lint branch April 4, 2020 02:25
@guillep2k
Copy link
Member

@lunny to prevent increasing gitea's binary file size, is it possible to add a conditional tag to build/vendor.go and prevent it from being compiled in the actual executable?

@lunny
Copy link
Member Author

lunny commented Apr 4, 2020

@guillep2k Have no idea how to resolve that currently. Once we add a tag on build/vendor.go, and when you make build locally, the go.mod will be changed I think.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants