Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better styling for code review comment textarea #11428

Merged
merged 7 commits into from
May 16, 2020
Merged

Better styling for code review comment textarea #11428

merged 7 commits into from
May 16, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 15, 2020 •
edited
Loading

Before:
chrome_2020-05-15_23-23-04

After:
chrome_2020-05-16_15-42-13

@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label May 15, 2020
@lafriks lafriks added this to the 1.12.0 milestone May 15, 2020
@silverwind
Copy link
Member

Can you align the left borders?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 15, 2020
@silverwind
Copy link
Member

I'm not sure if breaking the textarea's border with the tab is good idea. Maybe separate them with a small .25rem gap.

@CirnoT
Copy link
Contributor Author

CirnoT commented May 15, 2020 •
edited
Loading

Looks weird with a gap in my opinion; the gap would make sense if textarea was styled like others however.

chrome_2020-05-16_01-55-28

@CirnoT
Copy link
Contributor Author

CirnoT commented May 15, 2020

Aligned the textarea as you asked

@zeripath
Copy link
Contributor

I think the border needs to go on the div.ui.active.tab not the textarea. I'm getting a weird appearing corner issue:

Screenshot from 2020-05-16 13-26-31

@CirnoT
Copy link
Contributor Author

CirnoT commented May 16, 2020

Please check now

chrome_2020-05-16_15-05-28

@zeripath
Copy link
Contributor

That's better, thanks @CirnoT . Now should the corners have a radius ?

@CirnoT
Copy link
Contributor Author

CirnoT commented May 16, 2020

Pretty annoying because top corners can't be set (looks weird in Preview when only left is unset)

chrome_2020-05-16_15-33-35
chrome_2020-05-16_15-33-45

@CirnoT
Copy link
Contributor Author

CirnoT commented May 16, 2020

Okay, managed to fix the border edge case

chrome_2020-05-16_15-42-13
chrome_2020-05-16_15-42-44

zeripath
zeripath approved these changes May 16, 2020
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to sort out our border-radii in our less files... we have 3px, 6px, 4px, 5px, 50%, 100%, .28571429rem

Think we should set these to .28571429rem but otherwise LGTM

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 16, 2020
@CirnoT
Copy link
Contributor Author

CirnoT commented May 16, 2020 •
edited
Loading

Changed from .28rem to .28571429rem for consistency sake

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 16, 2020
@lunny lunny merged commit 6603045 into go-gitea:master May 16, 2020
@CirnoT CirnoT deleted the coder-textarea branch May 16, 2020 16:37
@snyk-bot snyk-bot mentioned this pull request Jul 10, 2020
Open
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@CirnoT
Better styling for code review comment textarea (go-gitea#11428)
e58b452 
* Better styling for code review comment textarea

* align tabular menu with textarea

* border around active tab instead of textarea

* border radius

* use .28571429rem
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
7 participants
@CirnoT @silverwind @zeripath @mrsdizzie @lunny @lafriks @GiteaBot