Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #1189, commit messages containing a pipe #1203

Merged
merged 1 commit into from
Mar 11, 2017
Merged

fix #1189, commit messages containing a pipe #1203

merged 1 commit into from
Mar 11, 2017

Conversation

philfry
Copy link
Contributor

@philfry philfry commented Mar 10, 2017

this patch makes graphItemFromString split only the first 8 elements, leaving commit messages with pipes in it untouched.

@lunny lunny added this to the 1.2.0 milestone Mar 11, 2017
@lunny lunny added the type/bug label Mar 11, 2017
@lunny
Copy link
Member

lunny commented Mar 11, 2017

will fix #1189

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 11, 2017
@lunny
Copy link
Member

lunny commented Mar 11, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 11, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 11, 2017
@lunny lunny merged commit e2b2fd6 into go-gitea:master Mar 11, 2017
@lunny
Copy link
Member

lunny commented Mar 11, 2017

@philfry could you also send a back port PR to release/v1.1 ?

@lunny lunny mentioned this pull request Mar 11, 2017
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Mar 11, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@philfry @lunny @appleboy @tboerger