Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Gitea commits API again returns commit summaries, not full messages #12186

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Regression: Gitea commits API again returns commit summaries, not full messages #12186

merged 1 commit into from
Jul 8, 2020

Conversation

kbadk
Copy link
Contributor

@kbadk kbadk commented Jul 8, 2020 •
edited
Loading

#6408 introduced a small regression switching the API to return git commit message summary not the whole message.

This PR causes the API to return the full message once again.

Closes #12185.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 8, 2020
zeripath
zeripath approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was just a simple mistaken regression in #6408

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 8, 2020
@zeripath zeripath merged commit cedbd36 into go-gitea:master Jul 8, 2020
@zeripath zeripath added type/bug issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself labels Jul 8, 2020
@zeripath zeripath added this to the 1.13.0 milestone Jul 8, 2020
@zeripath
Copy link
Contributor

zeripath commented Jul 8, 2020

@kbadk would you be able to send a backport to release/v1.12?

techknowlogick pushed a commit to techknowlogick/gitea that referenced this pull request Jul 8, 2020
@kbadk @techknowlogick
Fix regression: Gitea commits API again returns commit summaries, not…
7ce8bb2 
… full messages (go-gitea#12186)

Closes go-gitea#12185
@techknowlogick techknowlogick mentioned this pull request Jul 8, 2020
Merged
@zeripath zeripath added the backport/done All backports for this PR have been created label Jul 8, 2020
techknowlogick added a commit that referenced this pull request Jul 8, 2020
@techknowlogick @kbadk
Fix regression: Gitea commits API again returns commit summaries, not…
c3c246c 
… full messages (#12186) (#12187)

Closes #12185

Co-authored-by: Kristian Antonsen <kristian@derfor.dk>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@kbadk
Fix regression: Gitea commits API again returns commit summaries, not…
bb4c84b 
… full messages (go-gitea#12186)

Closes go-gitea#12185
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Regression: Gitea commits API again returns commit summaries, not full messages
4 participants
@kbadk @zeripath @jolheiser @GiteaBot