-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TrN for repository limit #12492
Add TrN for repository limit #12492
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12492 +/- ##
==========================================
- Coverage 43.07% 42.99% -0.08%
==========================================
Files 658 658
Lines 72454 72453 -1
==========================================
- Hits 31211 31154 -57
- Misses 36186 36268 +82
+ Partials 5057 5031 -26
Continue to review full report at Codecov.
|
options/locale/locale_en-US.ini
Outdated
@@ -697,6 +697,7 @@ archive.issue.nocomment = This repo is archived. You cannot comment on issues. | |||
archive.pull.nocomment = This repo is archived. You cannot comment on pull requests. | |||
|
|||
form.reach_limit_of_creation = You have already reached your limit of %d repositories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need use TrN
in here to handle singular and plural differences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "TrN" mean? I couldn't find anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
example:
gitea/templates/repo/activity.tmpl
Line 44 in eb60a5d
{{.i18n.Tr (TrN .i18n.Lang .Activity.ActivePRCount "repo.activity.active_prs_count_1" "repo.activity.active_prs_count_n") .Activity.ActivePRCount | Safe }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks like this solution is better, I will try to implement it.
I am sorry that I can't work on the pull request at the moment, but I will continue working on it when I have time. |
I wanted to work on the PR and first updated my fork... but GitHub automatically closed the PR. So please re-open it. |
Sorry, but I am not experienced enough with Go and the Gitea codebase. I thought I could make a little PR, but it turned out to be trickier. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☝️
@6543 it might be quicker to just do:
|
🚀 |
Adds a different message for users who have a limit of zero (technically <1) repositories.