Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to disable webhooks #13176

Merged
merged 7 commits into from
Feb 11, 2021
Merged

Added option to disable webhooks #13176

merged 7 commits into from
Feb 11, 2021

Conversation

pboguslawski
Copy link
Contributor

@pboguslawski pboguslawski commented Oct 16, 2020 •
edited by 6543
Loading

This mod introduces DISABLE_WEBHOOKS parameter in [security] section
of app.ini (by default set to false). If set to true it disables web
hooks feature. Any existing undelivered web hook tasks will be cancelled.
Any existing web hook definitions will be left untouched in db but
its delivery tasks will be ignored.

@pboguslawski
Added option to disable web hooks
07df661 
This mod introduces DISABLE_WEB_HOOKS parameter in [security] section
of app.ini (by default set to false). If set to true it disables web
hooks feature. Any existing undelivered web hook tasks will be cancelled.
Any existing web hook definitions will be left untouched in db but
its delivery tasks will be ignored.

Author-Change-Id: IB#1105130
techknowlogick
techknowlogick previously requested changes Oct 17, 2020
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Webhook is one word (per https://en.wikipedia.org/wiki/Webhook) could you update this PR to changes references to have it be one word instead of two?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 17, 2020
zeripath
zeripath reviewed Oct 17, 2020
View reviewed changes
custom/conf/app.example.ini Outdated Show resolved Hide resolved
docs/content/doc/advanced/config-cheat-sheet.en-us.md Outdated Show resolved Hide resolved
modules/setting/setting.go Outdated Show resolved Hide resolved
modules/setting/setting.go Outdated Show resolved Hide resolved
modules/templates/helper.go Outdated Show resolved Hide resolved
routers/routes/routes.go Outdated Show resolved Hide resolved
templates/admin/navbar.tmpl Outdated Show resolved Hide resolved
templates/org/settings/navbar.tmpl Outdated Show resolved Hide resolved
templates/repo/settings/nav.tmpl Outdated Show resolved Hide resolved
templates/repo/settings/navbar.tmpl Outdated Show resolved Hide resolved
@pboguslawski
Webhook spelling fixed
60b208f 
Webhook spelling fixed.

Fixes: 07df661
Related: go-gitea#13176 (review)
Author-Change-Id: IB#1105174
pboguslawski added a commit to ibpl/gitea that referenced this pull request Oct 18, 2020
@pboguslawski
Webhook spelling fixed
5b03ef5 
Webhook spelling fixed.

Fixes: bbedae6
Related: go-gitea#13176 (review)
Author-Change-Id: IB#1105174
@pboguslawski
Copy link
Contributor Author

Spelling fixed.

@codecov-io
Copy link

codecov-io commented Oct 18, 2020 •
edited
Loading

Codecov Report

Merging #13176 (faccdb0) into master (ef825bd) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13176      +/-   ##
==========================================
- Coverage   42.01%   42.00%   -0.01%     
==========================================
  Files         733      733              
  Lines       78715    78733      +18     
==========================================
+ Hits        33070    33072       +2     
- Misses      40213    40223      +10     
- Partials     5432     5438       +6
Impacted Files Coverage Δ
services/webhook/deliver.go 46.29% <0.00%> (-0.58%) ⬇️
services/webhook/webhook.go 51.42% <0.00%> (-1.00%) ⬇️
routers/api/v1/api.go 79.07% <69.23%> (-0.43%) ⬇️
routers/routes/macaron.go 92.82% <75.00%> (-0.35%) ⬇️
modules/setting/setting.go 49.71% <100.00%> (+0.09%) ⬆️
modules/templates/helper.go 49.72% <100.00%> (+0.27%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/indexer/stats/db.go 48.00% <0.00%> (-12.00%) ⬇️
modules/git/repo_language_stats_nogogit.go 57.44% <0.00%> (-6.39%) ⬇️
services/pull/pull.go 42.85% <0.00%> (+0.50%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef825bd...faccdb0. Read the comment docs.

@techknowlogick techknowlogick changed the title Added option to disable web hooks Added option to disable webhooks Oct 20, 2020
@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label Oct 20, 2020
@techknowlogick techknowlogick added this to the 1.14.0 milestone Oct 20, 2020
6543
6543 reviewed Oct 21, 2020
View reviewed changes
custom/conf/app.example.ini Outdated Show resolved Hide resolved
@pboguslawski
Parameter description fixed
a040cea 
Parameter description fixed.

Fixes: 07df661
Related: go-gitea#13176 (review)
Author-Change-Id: IB#1105174
pboguslawski added a commit to ibpl/gitea that referenced this pull request Oct 23, 2020
@pboguslawski
Parameter description fixed
7fabb9b 
Parameter description fixed.

Fixes: bbedae6
Related: go-gitea#13176 (review)
Author-Change-Id: IB#1105174
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 24, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Dec 25, 2020
@lafriks
Copy link
Member

lafriks commented Dec 27, 2020

please resolve conflicts

@stale stale bot removed the issue/stale label Dec 27, 2020
@pboguslawski
Copy link
Contributor Author

Master merged to this PR.

@6543
Copy link
Member

6543 commented Jan 19, 2021

@pboguslawski can you update again?

@pboguslawski
Copy link
Contributor Author

Master merged to this PR.

@6543
Copy link
Member

6543 commented Jan 26, 2021

@pboguslawski can you merge master into this and apply latest changes (look at 6433ba0 for more infos)

@6543
Copy link
Member

6543 commented Feb 4, 2021

@pboguslawski hope you dont mind if you could merge master into it/resolve conflicts

@pboguslawski
Copy link
Contributor Author

Master merged to this PR.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 10, 2021
@6543
Copy link
Member

6543 commented Feb 10, 2021

@pboguslawski need one update again :D

@pboguslawski
Copy link
Contributor Author

Just pressed update button on this page.

@techknowlogick techknowlogick merged commit 7d7007d into go-gitea:master Feb 11, 2021
@pboguslawski pboguslawski deleted the master-IB#1105174 branch February 12, 2021 07:57
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath left review comments

@khmarbaise khmarbaise khmarbaise approved these changes

@6543 6543 6543 approved these changes

@techknowlogick techknowlogick Awaiting requested review from techknowlogick

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
8 participants
@pboguslawski @codecov-io @lafriks @6543 @khmarbaise @techknowlogick @zeripath @GiteaBot