Handle and propagate errors when checking if paths are Dirs, Files or Exist

[zeripath]

com.IsFile and the like although simple do elide the difference with errors on filesystem reads and may cause incorrect intepretations.

This PR switches all uses of from com.Is* to util.Is* and makes a best guess as to what to do - mostly log and propagate the error up.

This may make some misbehaving systems and OSs appear less stable but ... at least the problems are not being elided anymore.

Fix #13175

(I'm calling this a fix for that issue because although I do not know what is behind the underlying issue here - a new bug report with logs following on from this change would be more useful.)

[zeripath]

missed returns post ctx.ServerError

[rozhuk-im]

if err == nil && !isExist {
or else if !isExist {
looks like I mark all suspect places.
In few places I found double error logging, but it is ok :)

[rozhuk-im]

IMHO in future other devs will make same errors, due to bad API design.
To prevent coding errors - better to change API to return not bool but enum: Exist, NotExist, Error and err.

[zeripath]

@rozhuk-im that is not idiomatic for go.

[rozhuk-im]

gitea/modules/structs/task.go

Line 30 in f2a3abc

TaskStatusRunning // 1 task is running

Probably, but similar things are used.

[codecov-io]

Codecov Report

Merging #13186 (84cdce4) into master (3f13e07) will decrease coverage by 0.05%.
The diff coverage is 23.93%.

@@            Coverage Diff             @@
##           master   #13186      +/-   ##
==========================================
- Coverage   42.25%   42.19%   -0.06%     
==========================================
  Files         697      697              
  Lines       76631    76825     +194     
==========================================
+ Hits        32377    32416      +39     
- Misses      38932    39061     +129     
- Partials     5322     5348      +26     

Impacted Files	Coverage Δ
cmd/dump.go	0.88% <0.00%> (-0.03%)	⬇️
cmd/web.go	0.00% <0.00%> (ø)
models/upload.go	0.00% <0.00%> (ø)
modules/auth/repo_form.go	39.83% <0.00%> (-1.77%)	⬇️
modules/git/hook.go	52.30% <0.00%> (-3.44%)	⬇️
modules/repository/adopt.go	0.00% <0.00%> (ø)
modules/repository/check.go	0.00% <0.00%> (ø)
modules/repository/generate.go	0.00% <0.00%> (ø)
modules/repository/hooks.go	19.64% <0.00%> (-1.72%)	⬇️
modules/setting/lfs.go	40.90% <0.00%> (-3.00%)	⬇️
... and 17 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f13e07...84cdce4. Read the comment docs.

[6543]

@zeripath can you resolve the conflicts?

[zeripath]

@6543 Conflicts resolved

[lafriks]

Tests fail

[zeripath]

Agh ! it looks like when I resolved conflicts I introduced a bug in repo_form.go. Should now be fixed.

[lafriks]

🚀

[techknowlogick]

🚀