Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor image paste code #13354

Merged
merged 3 commits into from
Nov 2, 2020
Merged

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Oct 29, 2020

Some minor refactors I did while investigating another issue. Functionality should be pretty much the same as before. New code should also handle pasting multiple images.

@a1012112796 I was unable to fix your paste bug. I think the bug is in CodeMirror itself and I was unable to prevent it from pasting the text alongside the image. It does work when you switch to <textarea/>, so this is another reason for #10729 and just go for <textarea/>.

Some minor refactors I did while investigating another issue.
Functionalily should be pretty much the same as before.
@codecov-io
Copy link

Codecov Report

Merging #13354 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13354   +/-   ##
=======================================
  Coverage   42.12%   42.12%           
=======================================
  Files         689      689           
  Lines       75851    75853    +2     
=======================================
+ Hits        31949    31952    +3     
+ Misses      38670    38667    -3     
- Partials     5232     5234    +2     
Impacted Files Coverage Δ
routers/api/v1/repo/issue_reaction.go 46.76% <0.00%> (-0.69%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
modules/queue/workerpool.go 60.00% <0.00%> (-2.05%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
services/pull/patch.go 55.68% <0.00%> (+1.70%) ⬆️
modules/log/event.go 61.79% <0.00%> (+1.88%) ⬆️
services/pull/check.go 51.82% <0.00%> (+2.91%) ⬆️
services/pull/temp_repo.go 29.78% <0.00%> (+3.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55801cf...f37570d. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 29, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 31, 2020
@lafriks lafriks added the type/enhancement An improvement of existing functionality label Oct 31, 2020
@lafriks lafriks added this to the 1.14.0 milestone Oct 31, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 2, 2020
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 842a757 into go-gitea:master Nov 2, 2020
@silverwind silverwind deleted the imgpaste branch November 2, 2020 17:16
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants