-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor image paste code #13354
Merged
Merged
Refactor image paste code #13354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some minor refactors I did while investigating another issue. Functionalily should be pretty much the same as before.
Codecov Report
@@ Coverage Diff @@
## master #13354 +/- ##
=======================================
Coverage 42.12% 42.12%
=======================================
Files 689 689
Lines 75851 75853 +2
=======================================
+ Hits 31949 31952 +3
+ Misses 38670 38667 -3
- Partials 5232 5234 +2
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Oct 29, 2020
lafriks
approved these changes
Oct 31, 2020
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Oct 31, 2020
mrsdizzie
approved these changes
Nov 2, 2020
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Nov 2, 2020
🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/enhancement
An improvement of existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor refactors I did while investigating another issue. Functionality should be pretty much the same as before. New code should also handle pasting multiple images.
@a1012112796 I was unable to fix your paste bug. I think the bug is in CodeMirror itself and I was unable to prevent it from pasting the text alongside the image. It does work when you switch to
<textarea/>
, so this is another reason for #10729 and just go for<textarea/>
.