Prevent clone protocol button flash on page load #13626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the saved active buttons would flash on page load because if delay involved in JS execution. Prevent these flashes bydisabling transitions on page load and run the script right after. It's not an ideal solution (which would require server-side storage of user settings like this) but I'd say better than before.
|
Ready for review, it's not a pretty fix but it works pretty well and there is no real way around a inline script in this case unfortunately. |
GiteaBot
added
the
lgtm/need 2
mrsdizzie
approved these changes
Nov 26, 2020
GiteaBot
added
lgtm/need 1
zeripath
approved these changes
Nov 26, 2020
GiteaBot
added
lgtm/done
lafriks
approved these changes
Nov 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the saved active button would flash up on page load because of the inherent delay involved in JS execution which is required for this localStorage setting. Prevent these flashes by disabling transitions on page load on the buttons and run the script that activates the button right after.
It's not an ideal solution (which would require server-side storage of user settings like this) but I'd say better than before.