Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Settings: Ignore empty language codes & validate #13755

Merged

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 30, 2020

  • Ignore incorect language codes
  • Validate lang code

ref:

@6543 6543 added this to the 1.14.0 milestone Nov 30, 2020
@6543 6543 added the type/enhancement An improvement of existing functionality label Nov 30, 2020
@codecov-io
Copy link

codecov-io commented Nov 30, 2020

Codecov Report

Merging #13755 (896f3b4) into master (3512c7e) will decrease coverage by 0.11%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13755      +/-   ##
==========================================
- Coverage   42.25%   42.14%   -0.12%     
==========================================
  Files         708      708              
  Lines       77168    77173       +5     
==========================================
- Hits        32608    32522      -86     
- Misses      39196    39303     +107     
+ Partials     5364     5348      -16     
Impacted Files Coverage Δ
modules/auth/user_form.go 39.65% <ø> (ø)
routers/user/setting/profile.go 39.32% <33.33%> (-0.56%) ⬇️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/indexer/stats/queue.go 52.94% <0.00%> (-23.53%) ⬇️
models/issue_comment.go 43.50% <0.00%> (-9.22%) ⬇️
modules/indexer/stats/db.go 43.47% <0.00%> (-8.70%) ⬇️
modules/notification/ui/ui.go 84.72% <0.00%> (-8.34%) ⬇️
modules/queue/unique_queue_channel.go 58.06% <0.00%> (-6.46%) ⬇️
modules/notification/mail/mail.go 33.33% <0.00%> (-5.75%) ⬇️
modules/git/commit.go 49.67% <0.00%> (-3.95%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3512c7e...896f3b4. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 30, 2020
@6543 6543 marked this pull request as ready for review December 1, 2020 09:49
@lafriks
Copy link
Member

lafriks commented Dec 1, 2020

tests seems to fail now

@6543 6543 force-pushed the user-settings-ignore-incorect-lang-value branch from a5453fe to 7584d19 Compare December 1, 2020 16:29
options/locale/locale_en-US.ini Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 1, 2020
@6543 6543 force-pushed the user-settings-ignore-incorect-lang-value branch from 9153147 to 531f7a3 Compare December 3, 2020 02:04
@6543 6543 added the pr/wip This PR is not ready for review label Dec 3, 2020
@6543 6543 force-pushed the user-settings-ignore-incorect-lang-value branch from 531f7a3 to ef6429d Compare December 3, 2020 02:20
@6543 6543 force-pushed the user-settings-ignore-incorect-lang-value branch from ef6429d to c0fd164 Compare December 3, 2020 02:36
@6543 6543 removed the pr/wip This PR is not ready for review label Dec 3, 2020
@6543
Copy link
Member Author

6543 commented Dec 3, 2020

@lafriks fixed :)

@6543 6543 changed the title User Settings: Ignore incorect language codes User Settings: Ignore empty language codes & validate Dec 3, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 4, 2020
@lafriks lafriks merged commit 48a3bb7 into go-gitea:master Dec 4, 2020
@lafriks lafriks deleted the user-settings-ignore-incorect-lang-value branch December 4, 2020 06:20
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Jan 13, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants