Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Table of Contents to long documentation pages #13890

Merged
merged 6 commits into from
Dec 8, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Dec 7, 2020

A redo of #13836

use new introduced shortcode (https://gitea.com/gitea/theme/pulls/90)

@6543 6543 added type/docs This PR mainly updates/creates documentation pr/wip This PR is not ready for review labels Dec 7, 2020
@6543 6543 removed the pr/wip This PR is not ready for review label Dec 7, 2020
@6543 6543 added this to the 1.14.0 milestone Dec 7, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 8, 2020
@codecov-io
Copy link

Codecov Report

Merging #13890 (f64a06c) into master (682f0b0) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13890   +/-   ##
=======================================
  Coverage   42.25%   42.26%           
=======================================
  Files         708      708           
  Lines       77191    77191           
=======================================
+ Hits        32620    32626    +6     
+ Misses      39211    39208    -3     
+ Partials     5360     5357    -3     
Impacted Files Coverage Δ
modules/log/event.go 58.96% <0.00%> (-0.95%) ⬇️
services/pull/check.go 51.09% <0.00%> (-0.73%) ⬇️
models/error.go 39.47% <0.00%> (+0.48%) ⬆️
modules/process/manager.go 75.00% <0.00%> (+2.50%) ⬆️
modules/indexer/stats/db.go 52.17% <0.00%> (+8.69%) ⬆️
modules/indexer/stats/queue.go 76.47% <0.00%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 682f0b0...f64a06c. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 8, 2020
@techknowlogick techknowlogick merged commit 6bdcacd into go-gitea:master Dec 8, 2020
@6543 6543 deleted the docs_toc branch December 8, 2020 04:58
@pat-s
Copy link
Member

pat-s commented Dec 8, 2020

A note on the new toc shortcode: h1 are not processed and pages should be updated to start at h2 by default so that all headers are included in the ToC.

I will do that now.

@pat-s pat-s mentioned this pull request Dec 8, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants