Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix label of --id in admin delete user #14005

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Dec 15, 2020

This pr fixes the label descriptor of gitea admin delete user
but also adds a --username and --email option.

Fix #13995

Signed-off-by: Andrew Thornton art27@cantab.net

This pr fixes the label descriptor of `gitea admin delete user`
but also adds a `--username` option.

Fix go-gitea#13995

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.14.0 milestone Dec 15, 2020
@codecov-io
Copy link

codecov-io commented Dec 15, 2020

Codecov Report

Merging #14005 (8156065) into master (9e456b5) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14005      +/-   ##
==========================================
+ Coverage   42.20%   42.22%   +0.01%     
==========================================
  Files         710      710              
  Lines       77295    77306      +11     
==========================================
+ Hits        32626    32645      +19     
- Misses      39290    39294       +4     
+ Partials     5379     5367      -12     
Impacted Files Coverage Δ
cmd/admin.go 0.00% <0.00%> (ø)
modules/log/event.go 59.90% <0.00%> (-1.89%) ⬇️
services/mailer/mail.go 60.21% <0.00%> (-1.08%) ⬇️
modules/notification/mail/mail.go 39.08% <0.00%> (ø)
models/issue_comment.go 52.71% <0.00%> (+0.45%) ⬆️
routers/repo/view.go 38.11% <0.00%> (+0.64%) ⬆️
models/error.go 39.31% <0.00%> (+0.81%) ⬆️
models/notification.go 67.24% <0.00%> (+0.98%) ⬆️
services/pull/check.go 51.09% <0.00%> (+1.45%) ⬆️
models/unit.go 49.31% <0.00%> (+2.73%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e456b5...8156065. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 15, 2020
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 16, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 17, 2020
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 5e09de1 into go-gitea:master Dec 17, 2020
@zeripath zeripath deleted the fix-13995-gitea-admin-user-delete---id-is-id branch December 17, 2020 18:21
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gitea admin user delete --help gives misleading documentation
6 participants