Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor get tag to remove unnecessary steps #14058

Merged
merged 2 commits into from
Dec 19, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 19, 2020

This PR removed some unnecessary codes from getTag and also fix a bug related with tagCache. A not about that:

Lightweight git tags may point to the same commit.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 19, 2020
@lunny lunny added the type/bug label Dec 19, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 19, 2020
@codecov-io
Copy link

Codecov Report

Merging #14058 (023f723) into master (4ef7512) will decrease coverage by 0.03%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14058      +/-   ##
==========================================
- Coverage   42.32%   42.29%   -0.04%     
==========================================
  Files         726      726              
  Lines       77684    77677       -7     
==========================================
- Hits        32883    32852      -31     
- Misses      39403    39435      +32     
+ Partials     5398     5390       -8     
Impacted Files Coverage Δ
modules/git/repo_tag.go 59.54% <75.00%> (+0.84%) ⬆️
modules/git/error.go 25.42% <0.00%> (-28.82%) ⬇️
modules/git/repo_base_nogogit.go 63.63% <0.00%> (-9.10%) ⬇️
modules/git/repo.go 39.41% <0.00%> (-4.12%) ⬇️
modules/log/event.go 58.96% <0.00%> (-2.84%) ⬇️
modules/git/utils.go 77.77% <0.00%> (-2.78%) ⬇️
modules/git/blame.go 65.71% <0.00%> (-1.43%) ⬇️
services/pull/pull.go 40.14% <0.00%> (-1.24%) ⬇️
modules/indexer/stats/db.go 48.00% <0.00%> (ø)
models/error.go 38.98% <0.00%> (+0.48%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aabbac...023f723. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 19, 2020
@lafriks lafriks merged commit 1d3a580 into go-gitea:master Dec 19, 2020
@lafriks lafriks added this to the 1.14.0 milestone Dec 19, 2020
@lunny lunny deleted the lunny/refactor_gettag branch December 19, 2020 23:46
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants