Check permission for the appropriate unit type #14261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes false positives for "User created Issues in Repository which they no longer have access to" errors
zeripath
approved these changes
Jan 5, 2021
GiteaBot
added
the
lgtm/need 1
|
the reason it exists is because of different bug - that was causing other issues - you'd need to look at the issues around the time it was merged. |
|
OK make it log.Trace or log.Debug |
lunny
approved these changes
Jan 6, 2021
GiteaBot
added
lgtm/done
|
Should we still put the |
Codecov Report
@@ Coverage Diff @@
## master #14261 +/- ##
==========================================
- Coverage 41.97% 41.86% -0.11%
==========================================
Files 735 742 +7
Lines 78933 79324 +391
==========================================
+ Hits 33132 33211 +79
- Misses 40346 40649 +303
- Partials 5455 5464 +9
Continue to review full report at Codecov.
|
lafriks
approved these changes
Jan 6, 2021
a1012112796
added a commit
to a1012112796/gitea
that referenced
this pull request
Jan 14, 2021
* master: (252 commits) Issues overview should not show issues from archived repos (go-gitea#13220) Display SVG files as images instead of text (go-gitea#14101) [skip ci] Updated translations via Crowdin Update docs to clarify issues raised in go-gitea#14272 (go-gitea#14318) [skip ci] Updated translations via Crowdin [Refactor] Passwort Hash/Set (go-gitea#14282) Add option to change username to the admin panel (go-gitea#14229) fix mailIssueCommentBatch for pull request (go-gitea#14252) Remove self from MAINTAINERS (go-gitea#14286) Do not reload page after adding comments in Pull Request reviews (go-gitea#13877) Fix session bug when introduce chi (go-gitea#14287) [skip ci] Updated translations via Crowdin Add secure/httpOnly attributes to the lang cookie (go-gitea#9690) (go-gitea#14279) Some code improvements (go-gitea#14266) [skip ci] Updated translations via Crowdin Fix wrong type on hooktask to convert typ from char(16) to varchar(16) (go-gitea#14148) Upgrade XORM links in documentation. (go-gitea#14265) Check permission for the appropriate unit type (go-gitea#14261) Add compliance check for windows to ensure cross platform build (go-gitea#14260) [skip ci] Updated translations via Crowdin ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes false positives for "User created Issues in Repository which they no longer have access to" errors
Or could lines 548-556 be removed entirely? Not sure whether this permission check is really useful. It doesn't enforce anything, it just logs an error?