[API] GetRelease by tag only return release

[cameronbraid]

get release by tag should filter out tag releases to be consistent with list releases and get by id

There is a inconsistency between the 'list releases for repo' and 'get release by tag'.

The former filters out any release that is_tag=true where as the later includes them.

So there is no consistent way to identify if a release exists for a given tag name.

If I iterate the 'list releases for repo' results it wont be there. If I use 'get release by tag' it will be there but won't have any fields like title/notes/commitssh

[cameronbraid]

Can I also backport this to release/v1.13 ?

[CirnoT]

Makes it even more inconsistent due to DELETE being used to remove tag.

Your solution is sound however it would require:

• Removing DELETE on ​/repos​/{owner}​/{repo}​/releases​/tags​/{tag} (having endpoint that removes tag grouped under release seems counter-intuitive anyway, release is not a tag nor can release have more than one tag)
• Adding GET for /repos/{owner}/{repo}/tags/{tag} to fetch specific tag
• Adding DELETE for /repos​/{owner}​/{repo}​/tags/{tag} to remove specific tag

[codecov-io]

Codecov Report

Merging #14397 (76da070) into master (0c0445c) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #14397      +/-   ##
==========================================
+ Coverage   41.84%   41.86%   +0.01%     
==========================================
  Files         744      744              
  Lines       79779    79782       +3     
==========================================
+ Hits        33387    33400      +13     
+ Misses      40874    40866       -8     
+ Partials     5518     5516       -2     

Impacted Files	Coverage Δ
routers/api/v1/repo/release_tags.go	48.38% <0.00%> (-5.19%)	⬇️
services/pull/check.go	48.52% <0.00%> (-0.74%)	⬇️
services/pull/pull.go	42.64% <0.00%> (+0.49%)	⬆️
models/repo_list.go	78.76% <0.00%> (+0.88%)	⬆️
modules/queue/workerpool.go	60.81% <0.00%> (+2.04%)	⬆️
modules/git/tree_entry_nogogit.go	93.75% <0.00%> (+6.25%)	⬆️
modules/util/timer.go	85.71% <0.00%> (+42.85%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c0445c...76da070. Read the comment docs.

[cameronbraid]

Not sure what you want conceptually for how gitea wants release/tags to function

From my limited understanding, a tag can exist without a release - however there is still a row in the release table for said tag

A release can be created for a tag which upgrades the row in the release table to be is_tag = false and fills on extra information

I assumes that the GET/DELETE on /repos​/{owner}​/{repo}​/releases​/tags​/{tag} were alternative endpoints for GET/DELETE on /repos/{owner}/{repo}/releases/{id} but doing the lookups buy tag name instead of release id

[CirnoT]

I assumes that the GET/DELETE on /repos​/{owner}​/{repo}​/releases​/tags​/{tag} were alternative endpoints for GET/DELETE on /repos/{owner}/{repo}/releases/{id} but doing the lookups buy tag name instead of release id

No, the DELETE endpoint works only if the release is is_tag=true and is used to remove tag via git itself:

gitea/routers/api/v1/repo/release_tags.go

Line 116 in 76da070

if err := releaseservice.DeleteReleaseByID(release.ID, ctx.User, true); err != nil {

gitea/services/release/release.go

Lines 149 to 155 in 8c086ba

	if delTag {
	if stdout, err := git.NewCommand("tag", "-d", rel.TagName).
	SetDescription(fmt.Sprintf("DeleteReleaseByID (git tag -d): %d", rel.ID)).
	RunInDir(repo.RepoPath()); err != nil && !strings.Contains(err.Error(), "not found") {
	log.Error("DeleteReleaseByID (git tag -d): %d in %v Failed:\nStdout: %s\nError: %v", rel.ID, repo, stdout, err)
	return fmt.Errorf("git tag -d: %v", err)
	}

By changing how GET endpoint works, you make it inconsistent with how DELETE behaves (note it can't be used to delete release!)

gitea/routers/api/v1/repo/release_tags.go

Lines 111 to 113 in 76da070

	if !release.IsTag {
	ctx.Error(http.StatusConflict, "IsTag", errors.New("a tag attached to a release cannot be deleted directly"))
	return

[6543]

this is a breaking change!
and should at first be considdered carefully!

[6543]

was added at #12932 related: #13358

[6543]

Summary of my review:

the #13358 is not jet been released ....

so we could make DELETE /repos/{owner}/{repo}/releases/tags/{tag} to be used as "delete release by tag"
we then have to add a delete git tag endpoint

I would suggest DELETE /repos/{owner}/{repo}/tags/{tag}
and add the check suggested by this pull ...

@cameronbraid ☝️ can you ajust this pull at least to the last one ... then I'll file a pull up myselve ... or you could go for the whole thing ;)

[johanvdw]

It seems the github api is also filtering out tags without release:
https://api.github.com/repos/go-gitea/gitea/releases/tags/v0.9.9
vs
https://api.github.com/repos/go-gitea/gitea/releases/tags/v1.0.0

[6543]

I'll adjust this pull & send a follow up ...

[6543]

🚀