Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ssh-keygen on Windows to detect ssh key type #14413

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Allow ssh-keygen on Windows to detect ssh key type #14413

merged 2 commits into from
Jan 21, 2021

Conversation

skyline75489
Copy link
Contributor

The code was from 5 years ago. This is simply not true any more. The ssh-keygen -lf result on Windows is exactly the same as Linux.

Without this, native SSH does not work on Windows.

@6543 6543 added this to the 1.14.0 milestone Jan 21, 2021
@6543 6543 added the type/enhancement An improvement of existing functionality label Jan 21, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 21, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 21, 2021
@6543
Copy link
Member

6543 commented Jan 21, 2021

🚀

@6543 6543 merged commit 072d550 into go-gitea:master Jan 21, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants