fix gpg API panic when no verification #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapk
reviewed
Apr 6, 2017
routers/api/v1/convert/convert.go
Outdated
| @@ -45,6 +45,11 @@ func ToCommit(c *git.Commit) *api.PayloadCommit { | |||
| committerUsername = committer.Name | |||
| } | |||
| verif := models.ParseCommitWithSignature(c) | |||
| var signature, payload string | |||
| if verif.Verified { | |||
There was a problem hiding this comment.
Should be c.Signature != nil because Verified could be false because we didn't validated the sign but the commit is signed.
|
Not tested but LGTM |
tboerger
added
the
lgtm/need 2
|
Thx for the quick fix of my mistake. |
appleboy
approved these changes
Apr 6, 2017
|
LGTM |
tboerger
added
lgtm/need 1
|
Trusted LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1383 @sapk please help to confirm.