Move the stopwatches to the eventsource stream #14588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the /user/events eventsource to update the stopwatches instead of polling /api/v1/user/stopwatches if the eventsource is enabled. Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
the
type/feature
zeripath
commented
Feb 6, 2021
| @@ -75,6 +81,32 @@ loop: | |||
| case <-shutdownCtx.Done(): | |||
| go unregister() | |||
| break loop | |||
| case <-stopwatchTimer.C: | |||
There was a problem hiding this comment.
This could be a little more efficient and happen in the modules/eventsource instead per uid.
GiteaBot
added
the
lgtm/need 2
|
I don't completely understand why this is polling in any case instead of looking for some change but moving the polling to /user/events will clean up the http log. |
6543
added
type/enhancement
|
|
|
actually I think it wasn't a local issue on your side - it was a real issue. I've fixed it now. Feel free to test again @6543 |
6543
approved these changes
Feb 13, 2021
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Feb 18, 2021
GiteaBot
added
lgtm/done
|
🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the /user/events eventsource to update the stopwatches
instead of polling /api/v1/user/stopwatches if the eventsource
is enabled.
Signed-off-by: Andrew Thornton art27@cantab.net