HasPreviousCommit causes recursive load of commits unnecessarily #14598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR improves HasPreviousCommit to prevent the automatic and recursive loading of previous commits using git merge-base --is-ancestor and git rev-list Related go-gitea#13684 Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
|
I think this is actually going to fix the associated problem. |
GiteaBot
added
the
lgtm/need 2
6 tasks
parnic-sks
reviewed
Feb 8, 2021
|
@zeripath Could you add some tests for this? |
Signed-off-by: Andrew Thornton <art27@cantab.net>
|
@lunny test added |
…r issue Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny
approved these changes
Feb 9, 2021
GiteaBot
added
lgtm/need 1
6543
approved these changes
Feb 10, 2021
GiteaBot
added
lgtm/done
|
Make lgtm work |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Feb 11, 2021
…gitea#14598) Backport go-gitea#14598 This PR improves HasPreviousCommit to prevent the automatic and recursive loading of previous commits using git merge-base --is-ancestor and git rev-list Fix go-gitea#13684 Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves HasPreviousCommit to prevent the automatic and recursive loading
of previous commits using git merge-base --is-ancestor and git rev-list
Fix #13684
Fix #13423
Signed-off-by: Andrew Thornton art27@cantab.net