Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the comment on comment type #14609

Merged
merged 3 commits into from
Feb 10, 2021
Merged

Improve the comment on comment type #14609

merged 3 commits into from
Feb 10, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 8, 2021

As title.

@lunny lunny added the type/docs This PR mainly updates/creates documentation label Feb 8, 2021
zeripath
zeripath approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful if we could use the constants in the templates but I think this is at least a bit better

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 8, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 10, 2021
@6543
Copy link
Member

6543 commented Feb 10, 2021

🚀

@6543 6543 merged commit c0c59a4 into go-gitea:master Feb 10, 2021
@lunny lunny deleted the lunny/comment_type_comment branch February 10, 2021 03:57
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @6543 @zeripath @GiteaBot