Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PATCH /repos/{owner}/{repo} panic #14637

Merged
merged 8 commits into from
Feb 11, 2021
Merged

Fix PATCH /repos/{owner}/{repo} panic #14637

merged 8 commits into from
Feb 11, 2021

Commits on Feb 10, 2021

  1. Fix a runtime error when modifying a repository through API call 

    Using the `PATCH /repos/{owner}/{repo}` endpoint and attempting to
modify `default_branch` on an empty repository will cause a
panic. This commit adds a check for a nil pointer before attempting
to dereference it.
    Anton Khimich committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    50996b8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix_patch_default_branch_panic

    Anton Khimich committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    c58f313 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2021

  1. Apply suggestions from code review

    @6543
    6543 authored Feb 11, 2021
    Configuration menu
    Copy the full SHA
    be5c83a View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @6543
    6543 authored Feb 11, 2021
    Configuration menu
    Copy the full SHA
    4f1711e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fix_patch_default_branch_panic

    @6543
    6543 authored Feb 11, 2021
    Configuration menu
    Copy the full SHA
    c3068b1 View commit details
    Browse the repository at this point in the history

  4. Ensure that the git repository is loaded 

    If you change the default branch for a repository you must change it in
git too. Therefore you must open the repository before changing the
default branch.

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    bf4164a View commit details
    Browse the repository at this point in the history

  5. Allow empty repos to have their default branches changed 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    28c47f9 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into fix_patch_default_branch_panic

    @zeripath
    zeripath authored Feb 11, 2021
    Configuration menu
    Copy the full SHA
    949ed90 View commit details
    Browse the repository at this point in the history