Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LFS data mirroring #14718

Closed
wants to merge 17 commits into from
Closed

Add LFS data mirroring #14718

wants to merge 17 commits into from

Conversation

bl00mber
Copy link

@bl00mber bl00mber commented Feb 17, 2021 •
edited
Loading

close #849

Peek 2021-03-01 21-46

Screenshot from 2021-03-01 21-47-47

  • https client for lfs download
  • LFS server input
  • download directly to lfs.storage
  • optional download of older lfs files
  • size restrictions
  • fetch LFS files on mirror update
  • remember LFS server on mirror update

close #14726

@bl00mber bl00mber force-pushed the lfs-data-mirroring branch 3 times, most recently from 231461c to e786de0 Compare February 18, 2021 00:36
@6543 6543 added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Feb 18, 2021
@6543 6543 added this to the 1.15.0 milestone Feb 18, 2021
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 18, 2021
@lunny
Copy link
Member

lunny commented Feb 18, 2021

How about to put LFS as one of migrations items?

lunny
lunny reviewed Feb 18, 2021
View reviewed changes
modules/repository/repo.go Outdated Show resolved Hide resolved
techknowlogick
techknowlogick reviewed Feb 18, 2021
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've had a (very) quick browse, one thing I noticed was that there is no check to see if git lfs is enabled on the server

zeripath
zeripath suggested changes Feb 18, 2021
View reviewed changes
modules/repository/repo.go Outdated Show resolved Hide resolved
@KN4CK3R
Copy link
Member

KN4CK3R commented Feb 18, 2021

I am currently working on the same thing: #14726

@6543
Copy link
Member

6543 commented Feb 18, 2021

I think "git lfs fetch " do not store recived lfs content in gitea's lfs storage ...

@bl00mber
Copy link
Author

bl00mber commented Feb 19, 2021 •
edited
Loading

Thanks for the review!

How about to put LFS as one of migrations items?

Should it be one of? Looks like it allows to download LFS without the access token? One of the main use cases may be to download 3rd-party misconfigured repos.

I think "git lfs fetch" do not store recived lfs content in gitea's lfs storage

Yeah it downloads to repo but then it moves files to gitea storage.
UPD: now it downloads files directly to gitea lfs storage.

@6543 6543 mentioned this pull request Feb 19, 2021
Merged
11 tasks
@bl00mber bl00mber force-pushed the lfs-data-mirroring branch from 0f98daf to 9982edb Compare March 1, 2021 16:55
@bl00mber bl00mber requested a review from zeripath March 1, 2021 17:00
@bl00mber bl00mber requested review from 6543 and lunny March 12, 2021 22:05
@lunny lunny removed this from the 1.15.0 milestone Apr 9, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick left review comments

@zeripath zeripath Awaiting requested review from zeripath

@6543 6543 Awaiting requested review from 6543

@lunny lunny Awaiting requested review from lunny

Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo mirroring doesn't mirror LFS data.
7 participants
@bl00mber @lunny @KN4CK3R @6543 @techknowlogick @zeripath @GiteaBot