Feature: Add milestones search by name on dashboard milestones page.

[rogerluo410]

Feature for issue 13845:
Add milestones search by name on dashboard milestones page.

• [Feature Request] Search box on Milestones page #13845

[noerw]

Somehow this value gets URL-encoded, which is not understood by gitea.
Maybe the backend should URI-decode properly, instead of fixing this on the frontend

[rogerluo410]

Hi, noerw, I didn't make sense of your suggestion. The %2C translates to a comma (,). What you mean is we should not use the encoding '%2c' in the URL query params on the frontend ?

I just reference it on the issue.tmpl （FYI:

gitea/templates/user/dashboard/issues.tmpl

Line 76 in acb1ceb

<input type="hidden" name="repos" value="[{{range $.RepoIDs}}{{.}}%2C{{end}}]"/>

）, there is the same way to generate the query params. And the backend uses the regular express var issueReposQueryPattern = regexp.MustCompile(^\[\d+(,\d+)*,?\]$) to fetch them from URL query params.

Maybe we should use a unified way to solve it in the whole project?

[noerw]

The issue is the double-escaped comma, the form handler that extracts the value from the hidden input already url-escapes.
To fix this:

Suggested change

	<input type="hidden" name="repos" value="[{{range $.RepoIDs}}{{.}}%2C{{end}}]"/>
	<input type="hidden" name="repos" value="[{{range $.RepoIDs}}{{.}},{{end}}]"/>

[rogerluo410]

replaced.

[noerw]

Looks good, but it would be nice to add this to the <repo>/milestones page as well.

[rogerluo410]

@noerw I created new PR to implement both features (search on dashboard / repo), It may close the PR after merging that PR. FYI: #14866