Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When Deleting Repository only explicitly close PRs whose base is not this repository #14823

Merged
merged 6 commits into from
Mar 1, 2021
Merged

When Deleting Repository only explicitly close PRs whose base is not this repository #14823

merged 6 commits into from
Mar 1, 2021

Conversation

zeripath
Copy link
Contributor

Fix #14775

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
When Deleting Repository only explicitly close PRs whose base is not …
4eff692 
…this repository

Fix go-gitea#14775

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.14.0 milestone Feb 27, 2021
@zeripath zeripath mentioned this pull request Feb 27, 2021
Closed
@codecov-io
Copy link

Codecov Report

Merging #14823 (4eff692) into master (3d8b5ad) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14823   +/-   ##
=======================================
  Coverage   42.22%   42.23%           
=======================================
  Files         771      771           
  Lines       82181    82183    +2     
=======================================
+ Hits        34697    34706    +9     
+ Misses      41832    41826    -6     
+ Partials     5652     5651    -1
Impacted Files Coverage Δ
services/pull/pull.go 42.43% <0.00%> (+0.28%) ⬆️
routers/repo/view.go 41.78% <0.00%> (+0.62%) ⬆️
modules/process/manager.go 75.30% <0.00%> (+2.46%) ⬆️
models/unit.go 49.31% <0.00%> (+2.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d8b5ad...4eff692. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 27, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 28, 2021
@noerw
Copy link
Member

noerw commented Feb 28, 2021

closes #14777

6543
6543 reviewed Mar 1, 2021
View reviewed changes
services/pull/pull.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 1, 2021
@6543
Copy link
Member

6543 commented Mar 1, 2021

🚀

@6543 6543 merged commit 59fd641 into go-gitea:master Mar 1, 2021
@zeripath zeripath deleted the fix-14775-only-close-prs-not-in-the-closing-repository branch March 1, 2021 21:05
zeripath added a commit to zeripath/gitea that referenced this pull request Mar 1, 2021
@zeripath
When Deleting Repository only explicitly close PRs whose base is not …
9a22e58 
…this repository (go-gitea#14823)

Backport go-gitea#14823

When Deleting Repository only explicitly close PRs whose base is not this repository

Fix go-gitea#14775

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request Mar 1, 2021
Merged
@zeripath zeripath added backport/done All backports for this PR have been created backport/v1.13 labels Mar 2, 2021
lunny pushed a commit that referenced this pull request Mar 2, 2021
@zeripath
When Deleting Repository only explicitly close PRs whose base is not …
d9d2e8f 
…this repository (#14823) (#14842)

Backport #14823

When Deleting Repository only explicitly close PRs whose base is not this repository

Fix #14775

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noerw noerw noerw approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Delete repository don't send issues notifications
5 participants
@zeripath @codecov-io @noerw @6543 @GiteaBot