Set HCaptchaSiteKey on Link Account pages #14834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using HCaptcha on link account pages the site key needs to be passed in. This PR ensures that HCaptchaSiteKey is set in the data. Fix go-gitea#14766 Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #14834 +/- ##
=======================================
Coverage 42.22% 42.22%
=======================================
Files 771 771
Lines 82181 82188 +7
=======================================
+ Hits 34702 34706 +4
- Misses 41826 41830 +4
+ Partials 5653 5652 -1
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
techknowlogick
approved these changes
Feb 28, 2021
GiteaBot
added
lgtm/need 1
jolheiser
approved these changes
Feb 28, 2021
GiteaBot
added
lgtm/done
|
🚀 |
|
Happy for anyone to send backport |
|
(or I'll do it at some point tomorrow) |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Mar 1, 2021
Backport go-gitea#14834 When using HCaptcha on link account pages the site key needs to be passed in. This PR ensures that HCaptchaSiteKey is set in the data. Fix go-gitea#14766 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
6543
pushed a commit
that referenced
this pull request
Mar 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using HCaptcha on link account pages the site key needs to be passed
in. This PR ensures that HCaptchaSiteKey is set in the data.
Fix #14766
Signed-off-by: Andrew Thornton art27@cantab.net