-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reverse proxy configuration support for remote IP address #14959
Add reverse proxy configuration support for remote IP address #14959
Conversation
how exactly is this supposed to work? |
I think for socket remote address should be 127.0.0.1 |
so they're considered as being one and the same here? |
I think yes, but that should probably needs to be tested |
would this be sort of activated by default if I build a new version? |
98e502d
to
c77fb7d
Compare
yes, it will be activated by default otherwise it will be insecure. By default it will trust single proxy server from localhost. |
9a881e5
to
82c735e
Compare
@lafriks can I have access to your fork so I can "update branch" as needed? |
@techknowlogick done |
🚀 |
By default trust single reverse proxy from loopback IP addresses (127.0.0.0/8, ::1/128)
In containerized environments by default trust requests from all IP addresses
EDIT: It is breaking change for users that use more then single reverse proxy to serve Gitea content