Do not allow commiting to protected branch from online editor

[lafriks]

Fix issue #1498

[strk]

Could you please add a unit test for this too ?

[lafriks]

As there are no unittests for editor I dont think I have time to add them

[strk]

Unit tests are a great way to secure the time spent on fixing a bug. That time could be easily wasted if there's no test making sure nobody breaks again what you fixed.

[lafriks]

Yes, I know but as there are no integration tests yet, I don't see how I can implement them...

[strk]

See the integrations/ directory. @typeless maybe you can add a README there to help people add tests ?

[typeless]

@strk /integrations is going to be replaced by #1290 soon. Please take a look.

[lunny]

LGTM

[strk]

#1290 is now merged. @lafriks do you want to give it a try?

[lafriks]

I will take a look

[lafriks]

Was not easy as there was no single authorized user integration test, so had to add quite many new stuff to integration tests. I did not want to introduce new dependency but in future it would probably be wise to replace my html parser to something like github.com/PuerkitoBio/goquery

[strk]

LGTM, thanks for the time you put into the tests !