Feature: link to previous blames in view blame page #15171
Conversation
|
Perhaps the versions octicon, to match GH? |
GiteaBot
added
the
lgtm/need 2
lunny
added
the
type/feature
|
The linter complains: |
Codecov Report
@@ Coverage Diff @@
## master #15171 +/- ##
=========================================
Coverage ? 43.56%
=========================================
Files ? 668
Lines ? 80604
Branches ? 0
=========================================
Hits ? 35113
Misses ? 39784
Partials ? 5707
Continue to review full report at Codecov.
|
Fixed |
Updated svg |
|
Please resolve conflicts. |
| padding-left: 10px; | ||
| padding-right: 10px; | ||
| text-align: right !important; | ||
| background-color: #f5f5f5; |
There was a problem hiding this comment.
This background color needs to overridden in web_src/less/themes/them-arc-green.less L464:
.blame .lines-num,
.blame .lines-blame-button {
There was a problem hiding this comment.
silverwind did the transition to them for colors ...
So you dont have to touch our dark theme!
There was a problem hiding this comment.
In that case, the existing override for .blame .lines-num in theme-arc-green.less can probably dropped
| ctx.Data["BlameContent"] = gotemplate.HTML(codeLines.String()) | ||
| ctx.Data["BlameCommitInfo"] = gotemplate.HTML(commitInfo.String()) | ||
| ctx.Data["BlameLineNums"] = gotemplate.HTML(lineNumbers.String()) | ||
| ctx.Data["Codes"] = rows |
|
@noerw @rogerluo410 thanks for the work -> merged as 9c6aeb4 |
Feature:
Related PR:
#15148
Feature request issue:
#15109
Hi, @noerw, I noticed you created a PR for the request, perhaps this one could more helpful to what we ask for.
Performance:
