Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug on status API #1533

Merged
merged 1 commit into from
Apr 24, 2017
Merged

fix bug on status API #1533

merged 1 commit into from
Apr 24, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 22, 2017

This will fix bug caused by #1332

@lunny lunny added the type/bug label Apr 22, 2017
@lunny lunny added this to the 1.2.0 milestone Apr 22, 2017
@strk
Copy link
Member

strk commented Apr 22, 2017

How about adding a testcase for this ? Presence of such test would have prevented this break ...

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 22, 2017
@bkcsoft
Copy link
Member

bkcsoft commented Apr 23, 2017

Adding a test-cast for the rest of the commands would be fairly simple yes.

@bkcsoft
Copy link
Member

bkcsoft commented Apr 23, 2017

but otherwise LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 23, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 23, 2017
@lunny lunny merged commit 3012971 into go-gitea:master Apr 24, 2017
@lunny lunny deleted the lunny/fix_status_api branch April 24, 2017 14:34
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @strk @bkcsoft @appleboy @tboerger