Monaco improvements #15333
Merged
Monaco improvements #15333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
silverwind
commented
Apr 7, 2021
silverwind
commented
- Create theme at runtime which follows the CSS variables of the site
- Disable a few opinionated Monaco defaults like minimap and word highlights
- Move styles to separate file
silverwind
force-pushed
the
editor-improvments
branch
2 times, most recently
from
6464e4f
to
8bd55c7
Compare
- Create theme at runtime which follows the CSS variables of the site - Disable a few opinionated Monaco defaults like minimap and word highlights - Move styles to separate file
silverwind
force-pushed
the
editor-improvments
branch
from
8bd55c7
to
d7c52ab
Compare
|
Labeling for backport as well as this is low-risk but nice improvement imho :) |
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Apr 8, 2021
GiteaBot
added
lgtm/need 1
zeripath
approved these changes
Apr 8, 2021
GiteaBot
added
lgtm/done
|
make L-G-T-M work. |
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Apr 8, 2021
- Create theme at runtime which follows the CSS variables of the site - Disable a few opinionated Monaco defaults like minimap and word highlights - Move styles to separate file Co-authored-by: zeripath <art27@cantab.net>
6543
pushed a commit
that referenced
this pull request
Apr 8, 2021
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Apr 8, 2021
It produces odd rgba values which also seem to cause issues in monaco's color parser where the scoll shadow went red for some reason. Regression by: go-gitea#15333
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Apr 8, 2021
It produces odd rgba values which also seem to cause issues in monaco's color parser where the scoll shadow went red for some reason. Regression by: go-gitea#15333
zeripath
pushed a commit
that referenced
this pull request
Apr 8, 2021
It produces odd rgba values which also seem to cause issues in monaco's color parser where the scoll shadow went red for some reason. Regression by: #15333
6543
pushed a commit
that referenced
this pull request
Apr 9, 2021
It produces odd rgba values which also seem to cause issues in monaco's color parser where the scoll shadow went red for some reason. Regression by: #15333
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.