-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move shutdownfns, terminatefns and hammerfns out of separate goroutines #15686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coalesce the shutdownfns etc into a list of functions that get run at shutdown rather then have them run at goroutines blocked on selects. This may help reduce the background select/poll load in certain configurations. Signed-off-by: Andrew Thornton <art27@cantab.net>
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Apr 30, 2021
6 tasks
Signed-off-by: Andrew Thornton <art27@cantab.net>
KN4CK3R
reviewed
Apr 30, 2021
KN4CK3R
reviewed
Apr 30, 2021
KN4CK3R
reviewed
Apr 30, 2021
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
changed the title
move shutdownfns, terminatefns and hammerfns out of separate goroutines
Move shutdownfns, terminatefns and hammerfns out of separate goroutines
May 1, 2021
Codecov Report
@@ Coverage Diff @@
## master #15686 +/- ##
==========================================
- Coverage 43.90% 43.88% -0.03%
==========================================
Files 678 678
Lines 81868 81883 +15
==========================================
- Hits 35946 35934 -12
- Misses 40075 40096 +21
- Partials 5847 5853 +6
Continue to review full report at Codecov.
|
I'm gonna close this to move its changes in to #15693 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
performance/speed
performance issues with slow downs
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coalesce the shutdownfns etc into a list of functions that get run at shutdown
rather then have them run at goroutines blocked on selects.
This may help reduce the background select/poll load in certain
configurations.
Signed-off-by: Andrew Thornton art27@cantab.net