Queue manager FlushAll can loop rapidly - add delay #15733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add delay within FlushAll to prevent rapid loop when workers are busy Signed-off-by: Andrew Thornton <art27@cantab.net>
|
Looking at the testing logs we get: This should stop that. |
GiteaBot
added
the
lgtm/need 2
6543
approved these changes
May 7, 2021
GiteaBot
added
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## main #15733 +/- ##
==========================================
- Coverage 43.94% 43.94% -0.01%
==========================================
Files 678 678
Lines 81945 81944 -1
==========================================
- Hits 36013 36008 -5
- Misses 40061 40064 +3
- Partials 5871 5872 +1
Continue to review full report at Codecov.
|
lunny
reviewed
May 7, 2021
Signed-off-by: Andrew Thornton <art27@cantab.net>
12 tasks
techknowlogick
approved these changes
May 11, 2021
GiteaBot
added
lgtm/done
|
Make lgtm work |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
May 12, 2021
Backport go-gitea#15733 * Queue manager FlushAll can loop rapidly - add delay Add delay within FlushAll to prevent rapid loop when workers are busy Signed-off-by: Andrew Thornton <art27@cantab.net> * as per lunny Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
that referenced
this pull request
May 12, 2021
Backport #15733 * Queue manager FlushAll can loop rapidly - add delay Add delay within FlushAll to prevent rapid loop when workers are busy Signed-off-by: Andrew Thornton <art27@cantab.net> * as per lunny Signed-off-by: Andrew Thornton <art27@cantab.net>
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
* Queue manager FlushAll can loop rapidly - add delay Add delay within FlushAll to prevent rapid loop when workers are busy Signed-off-by: Andrew Thornton <art27@cantab.net> * as per lunny Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: 6543 <6543@obermui.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add delay within FlushAll to prevent rapid loop when workers are busy
Related #15542
Signed-off-by: Andrew Thornton art27@cantab.net