-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix API to use author for commits instead of committer #16276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
added
type/bug
modifies/api
This PR adds API routes or modifies them
backport/v1.14
labels
Jun 27, 2021
zeripath
approved these changes
Jun 27, 2021
GiteaBot
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Jun 27, 2021
noerw
approved these changes
Jun 27, 2021
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Jun 27, 2021
Codecov Report
@@ Coverage Diff @@
## main #16276 +/- ##
==========================================
+ Coverage 45.40% 45.42% +0.01%
==========================================
Files 709 709
Lines 83484 83484
==========================================
+ Hits 37910 37919 +9
+ Misses 39495 39481 -14
- Partials 6079 6084 +5
Continue to review full report at Codecov.
|
zeripath
changed the title
[API] Convert Commit for api respect author
Fix API to use author for commits instead of committer
Jun 27, 2021
Please send backport. |
6543
added a commit
to 6543-forks/gitea
that referenced
this pull request
Jun 27, 2021
techknowlogick
pushed a commit
that referenced
this pull request
Jun 28, 2021
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/api
This PR adds API routes or modifies them
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in modules/convert.ToCommit where the committer is used in place of the author.
This PR fixes this.