Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Issue Index before querying DB #16406

Merged
merged 4 commits into from
Jul 12, 2021
Merged

Validate Issue Index before querying DB #16406

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d6ab65
dont try to find issue when index == 0
noerw Jul 12, 2021
b10b7d8
show 404
6543 Jul 12, 2021
5cc8b4b
Merge branch 'main' into fix/invalid-issue-index
techknowlogick Jul 12, 2021
f97d449
Merge branch 'main' into fix/invalid-issue-index
6543 Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions models/issue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1018,6 +1018,9 @@ func NewIssue(repo *Repository, issue *Issue, labelIDs []int64, uuids []string)

// GetIssueByIndex returns raw issue without loading attributes by index in a repository.
func GetIssueByIndex(repoID, index int64) (*Issue, error) {
if index < 1 {
return nil, ErrIssueNotExist{}
}
issue := &Issue{
RepoID: repoID,
Index: index,
Expand Down