-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport] fix sanitation #1646
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add code-injection checks
appleboy
approved these changes
Apr 30, 2017
LGTM |
tboerger
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Apr 30, 2017
lunny
requested changes
Apr 30, 2017
modules/markdown/sanitizer.go
Outdated
// Multiple calls to this function will only create one instance of Sanitizer during | ||
// entire application lifecycle. | ||
func NewSanitizer() { | ||
log.Trace("Markdown: sanitizer initialization requested") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember this will break SSH
modules/markdown/sanitizer.go
Outdated
// Custom URL-Schemes | ||
sanitizer.policy.AllowURLSchemes(setting.Markdown.CustomURLSchemes...) | ||
|
||
log.Trace("Markdown: sanitizer initialized") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this line.
lunny
approved these changes
Apr 30, 2017
LGTM |
tboerger
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Apr 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1461