Add basic edit ldap auth test & actually fix #16252 (#16465) #16494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#16465) Backport go-gitea#16465 One of the reasons why go-gitea#16447 was needed and why go-gitea#16268 was needed in the first place was because it appears that editing ldap configuration doesn't get tested. This PR therefore adds a basic test that will run the edit pipeline. In doing so it's now clear that go-gitea#16447 and go-gitea#16268 aren't actually solving go-gitea#16252. It turns out that what actually happens is that is that the bytes are actually double encoded. This PR now changes the json unmarshal wrapper to handle this double encode. Fix go-gitea#16252 Signed-off-by: Andrew Thornton <art27@cantab.net>
6543
approved these changes
Jul 20, 2021
GiteaBot
added
the
lgtm/need 1
6543
added
the
skip-changelog
KN4CK3R
reviewed
Jul 22, 2021
| host, _ := doc.Find(`input[name="host"]`).Attr("value") | ||
| assert.Equal(t, host, getLDAPServerHost()) | ||
| binddn, _ := doc.Find(`input[name="bind_dn"]`).Attr("value") | ||
| assert.Equal(t, binddn, "uid=gitea,ou=service,dc=planetexpress,dc=com") |
There was a problem hiding this comment.
Switch the expected and actual parameters.
There was a problem hiding this comment.
This is a backport so the problem needed to have been caught in the original PR.
KN4CK3R
approved these changes
Jul 22, 2021
GiteaBot
added
lgtm/done
|
Fixes #16448 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #16465
One of the reasons why #16447 was needed and why #16268 was needed in
the first place was because it appears that editing ldap configuration
doesn't get tested.
This PR therefore adds a basic test that will run the edit pipeline.
In doing so it's now clear that #16447 and #16268 aren't actually
solving #16252. It turns out that what actually happens is that is that
the bytes are actually double encoded.
This PR now changes the json unmarshal wrapper to handle this double
encode.
Fix #16252
Fix #16447
Fix #16288
Signed-off-by: Andrew Thornton art27@cantab.net