-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize list header for API #16551
Conversation
Codecov Report
@@ Coverage Diff @@
## main #16551 +/- ##
==========================================
+ Coverage 45.36% 45.40% +0.03%
==========================================
Files 758 758
Lines 85120 85258 +138
==========================================
+ Hits 38612 38708 +96
- Misses 40245 40277 +32
- Partials 6263 6273 +10
Continue to review full report at Codecov.
|
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath your commit break this pull :/ |
@lunny anything else you like to know? |
A helper method may be useful. At the moment there are 37 duplicated code blocks of ctx.Header().Set("X-Total-Count", fmt.Sprintf("%d", totalCount))
ctx.Header().Set("Access-Control-Expose-Headers", "X-Total-Count") If the |
had that in mind to ... was lazy and thought ... do it next time 😅 - u catched me will refactor bit more then ... |
🚀 |
close #11114