Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Use node v14 instead of node v16 untill it will pass again #16595

Merged
merged 4 commits into from
Aug 2, 2021
Merged

[CI] Use node v14 instead of node v16 untill it will pass again #16595

merged 4 commits into from
Aug 2, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Aug 1, 2021 •
edited
Loading

@6543 6543 added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 1, 2021
@6543 6543 added this to the 1.16.0 milestone Aug 1, 2021
zeripath
zeripath approved these changes Aug 1, 2021
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH if we're doing this we should really change to 1.14 full stop

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 1, 2021
@6543
Copy link
Member Author

6543 commented Aug 1, 2021

hmm can do it ... then just go back to 1.14 until fix

@6543 6543 changed the title [CI] release-latest: use node 14 (lts) to build until 16 do fail [CI] Use node v14 instead of node v16 untill it will pass again Aug 1, 2021
@6543
Copy link
Member Author

6543 commented Aug 1, 2021

@zeripath ajusted

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2021 •
edited
Loading

Codecov Report

Merging #16595 (db96025) into main (72738f0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16595      +/-   ##
==========================================
+ Coverage   45.35%   45.37%   +0.01%     
==========================================
  Files         750      750              
  Lines       85096    85098       +2     
==========================================
+ Hits        38599    38609      +10     
+ Misses      40252    40244       -8     
  Partials     6245     6245
Impacted Files Coverage Δ
routers/api/v1/repo/topic.go 47.47% <ø> (ø)
routers/api/v1/user/app.go 52.71% <ø> (ø)
services/wiki/wiki.go 58.45% <100.00%> (+0.89%) ⬆️
modules/process/manager.go 72.83% <0.00%> (-2.47%) ⬇️
modules/queue/workerpool.go 53.81% <0.00%> (-0.77%) ⬇️
services/pull/pull.go 41.73% <0.00%> (ø)
services/pull/patch.go 55.93% <0.00%> (+1.69%) ⬆️
services/pull/check.go 28.27% <0.00%> (+2.75%) ⬆️
services/pull/temp_repo.go 34.61% <0.00%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3375e76...db96025. Read the comment docs.

@6543 6543 mentioned this pull request Aug 1, 2021
Merged
silverwind
silverwind approved these changes Aug 1, 2021
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think we use any node 16 feature yet, so this should work.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 1, 2021
@6543 6543 merged commit 24366ed into go-gitea:main Aug 2, 2021
@6543 6543 deleted the fix-release branch August 2, 2021 01:47
6543 added a commit to 6543-forks/gitea that referenced this pull request Aug 2, 2021
@6543
[CI] Use node v14 instead of node v16 untill it will pass again (go-g…
5adeba4 
…itea#16595)

* for CI release: use node 14 (lts) to build until 16 do fail

* all in for node v14.x
@6543 6543 mentioned this pull request Aug 2, 2021
Merged
zeripath pushed a commit that referenced this pull request Aug 2, 2021
@6543
[CI] Use node v14 instead of node v16 until it will pass again (#16595)…
763e419 
… (#16599)

* for CI release: use node 14 (lts) to build until 16 do fail

* all in for node v14.x
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@6543 @AbdulrhmnGhanem
[CI] Use node v14 instead of node v16 untill it will pass again (go-g…
6ab08bf 
…itea#16595)

* for CI release: use node 14 (lts) to build until 16 do fail

* all in for node v14.x
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@6543 @codecov-commenter @silverwind @zeripath @GiteaBot @techknowlogick