Separate open and closed issue in metrics

[romdum]

Hi,

My team and I need to separate closed and open issue in exposed metrics.

The purpose is to have the number of open and closed issues by week in a Grafana dashboard.

[codecov-commenter]

Codecov Report

Merging #16637 (ed1f319) into main (620c569) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #16637      +/-   ##
==========================================
- Coverage   45.41%   45.38%   -0.03%     
==========================================
  Files         756      756              
  Lines       85247    85279      +32     
==========================================
- Hits        38713    38707       -6     
- Misses      40274    40309      +35     
- Partials     6260     6263       +3     

Impacted Files	Coverage Δ
models/models.go	53.42% <0.00%> (-2.56%)	⬇️
modules/metrics/collector.go	0.00% <0.00%> (ø)
modules/util/timer.go	42.85% <0.00%> (-42.86%)	⬇️
modules/queue/workerpool.go	53.05% <0.00%> (-1.91%)	⬇️
modules/queue/queue_channel.go	95.00% <0.00%> (-1.67%)	⬇️
modules/log/file.go	73.60% <0.00%> (-1.61%)	⬇️
routers/web/repo/view.go	41.52% <0.00%> (+0.57%)	⬆️
models/repo_list.go	77.64% <0.00%> (+0.78%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 620c569...ed1f319. Read the comment docs.

[lafriks]

I think old metric should be kept to not break compatibility

[zeripath]

Oh I missed that they'd removed that! Sorry for the bad review

[romdum]

If we keep Issue metrics, may be it's not necessary to keep IssueOpen metrics because: Issue - IssueClosed = IssueOpen ?

[zeripath]

So as these metrics are not produced within a transaction you can't actually assume that.

(We have to keep Issues anyway because of the dashboard.)

[zeripath]

OK I've made a little change which means that the counts are collected in one query.