Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting X-FRAME-OPTIONS #16643

Merged
merged 2 commits into from
Aug 6, 2021
Merged

Allow setting X-FRAME-OPTIONS #16643

merged 2 commits into from
Aug 6, 2021

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Aug 6, 2021

This PR provides a mechanism to set the X-FRAME-OPTIONS header.

Fix #7951

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Allow setting X-FRAME-OPTIONS
dc8b944 
This PR provides a mechanism to set the X-FRAME-OPTIONS header.

Fix go-gitea#7951

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the type/enhancement An improvement of existing functionality label Aug 6, 2021
@techknowlogick techknowlogick added this to the 1.16.0 milestone Aug 6, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 6, 2021
jolheiser
jolheiser reviewed Aug 6, 2021
View reviewed changes
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit

docs/content/doc/advanced/config-cheat-sheet.en-us.md Outdated Show resolved Hide resolved
@zeripath @jolheiser
Update docs/content/doc/advanced/config-cheat-sheet.en-us.md
13dc394 
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 6, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16643 (13dc394) into main (067d82b) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #16643   +/-   ##
=======================================
  Coverage   45.41%   45.41%           
=======================================
  Files         756      756           
  Lines       85247    85247           
=======================================
+ Hits        38713    38714    +1     
+ Misses      40271    40270    -1     
  Partials     6263     6263
Impacted Files Coverage Δ
modules/setting/cors.go 33.33% <ø> (ø)
routers/install/routes.go 45.76% <0.00%> (ø)
routers/web/base.go 17.14% <0.00%> (ø)
modules/context/api.go 73.63% <100.00%> (ø)
modules/context/context.go 60.91% <100.00%> (ø)
modules/charset/charset.go 71.71% <0.00%> (-4.05%) ⬇️
services/pull/pull.go 41.73% <0.00%> (ø)
modules/queue/workerpool.go 53.81% <0.00%> (+0.76%) ⬆️
models/gpg_key_common.go 64.51% <0.00%> (+4.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 067d82b...13dc394. Read the comment docs.

@techknowlogick techknowlogick merged commit afd88a2 into go-gitea:main Aug 6, 2021
@zeripath zeripath deleted the fix-7951-allow-setting-x-frame-options branch August 6, 2021 21:29
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

Proposal : Permit modification of X-FRAME-OPTIONS headers
5 participants
@zeripath @codecov-commenter @techknowlogick @jolheiser @GiteaBot